Adam Sven Johnson

Results 44 comments of Adam Sven Johnson

Using the `Accept-Language` header looks like it's also valid now\* too http://code.flickr.net/2009/12/04/language-detection-a-witchs-brew/ - well for ages, just superstition has made people think otherwise

1) Yes. question should be required, as both branches are required so a decision has to be made at some point. It makes no sense to ignore the whole branch.

@ldodds do you have an example certificate for that, it looks like it's showing headings that only make sense when the answer is yes (and yes is replaced with a...

Eg. to see which answers are common between certificates.

Hi @Quantumplation, There's not much in `instrumentation.go` that's mostly some helpers to build up log output for request events. `metrics.go` has the prometheus implementation. It could be refactored to allow...

Hi @benzolium, This looks cool, I'll give it a test when I have a chance. Is it possible you could add an example server to the `examples` folder to show...

It's probably worth removing the request body from the logging by default, it was in there initially as it was useful during early development. For now you could stop it...

@benzolium I tried testing the example service but I'm getting these errors ```json { "errors": [ { "message": "unexpected response code: 422 Unprocessable Entity", "locations": [ { "line": 2, "column":...

@benzolium I had a bunch more suggestions that were a bit too big to do through the review system. If you'd like to [look at my fork](https://github.com/benzolium/bramble/compare/multipart-file-upload...pkqk:multipart-suggestions?expand=1) Also looking through...

Hi @benzolium, good questions, performance wise, we are dealing with a lot of json parsing and serialisation which is going to be an order of magnitude slower than any of...