Peter Kieltyka comments

Results 198 comments of


                                            Peter Kieltyka

open-telemetry

thanks @Isnor :) what do you propose.. this package is largely outdated

Add how to use in readme

For sure.. in mean time, see https://github.com/go-chi/httptracer/blob/master/_example/main.go

Does not connect to specified network apparently randomly

thanks for the feedback :) we'll look to keep improving the library to smooth out these edges

OpenAPI Spec Validation Feature or Guidance

chi is a minimal library, what you’re describing is best suited to be built on top and independently of chi. For example see https://github.com/webrpc/webrpc and https://github.com/webrpc/gen-openapi

Revoke/terminate session on disconnect

We've discussed this -- and it might be confusing to the user to have something like a `wallet.signout()` method which prompt them to sign out of their wallet. Instead, we're...

using 64 bit hash instead of 32

I'm confused by https://github.com/elastic/go-freelru/issues/77#issuecomment-2615803227 .. we either have 64bits of entropy or 32bits of entropy.. what else is there to discuss..? we will get fewer collisions in 64bit hashes then...

using 64 bit hash instead of 32

thanks for explaining :) makes perfect sense

enum codegen for string type with value

Thanks for the kind words :) glad you’re enjoying! it seems what you’ve reported is a bug, as it should respect the string value of the enum you define

Build exponential backoff into webrpc clients

good idea.. makes sense for both Go and TS clients

Sign message enters an endless loop when choosing who signs

btw, @Quicksaver the EIP712 domain is very similar to what we do with https://github.com/0xsequence/ethauth.js -- which in fact is built into sequence.js and used on connect. See https://docs.sequence.xyz/wallet/guides/auth-address#authenticate-wallet and https://github.com/0xsequence/sequence.js/blob/master/packages/provider/src/types.ts#L157...