Peter Kieltyka

Results 138 comments of Peter Kieltyka

@jmoiron I've been working towards this, the first part of the work like we talked about on irc is to expand on reflectx. I've done some work here: https://github.com/pkieltyka/sqlx and...

After more consideration, I feel reflectx needs to change even more. I thought I could keep the fieldMap as a map[] .. but, instead the `fieldMap` type should just go...

I have a working implementation here: https://github.com/jmoiron/sqlx/compare/master...pkieltyka:master - it's been largely refactored, cleaned up with lots more tests since the weekend. You'll notice there haven't been any changes to sqlx,...

Also, try uncommenting https://github.com/pkieltyka/sqlx/blob/master/reflectx/reflect_test.go#L246-L248 and run the tests to have a look at the fieldInfo structure to get a better idea of the structure.

I wrote another branch that is optimized for cached types, as well using points: https://github.com/jmoiron/sqlx/compare/master...pkieltyka:ptrs

Let's ship this thing! check out: https://github.com/pkieltyka/sqlx/commit/eaab23ebcbb10596ecb51da75568fb729ce4247d

hmm.. I feel we should close this since and open more specific ideas for how to improve Join further. @nubbel most of the functionality discussed above has been merged for...

@eslammostafa my proposal was merged a long time ago, so I believe it should work today with sqlx (it did at some point). Another option is https://github.com/upper/db which supports these...