Peter Kieltyka comments

Results 198 comments of


                                            Peter Kieltyka

WebRTC data channel support

first you need a webrtc data channel implementation in Go ... no? I'm not aware of any, I've looked before and even considered implementing it

btw, with the settling of the http/2 spec and the work by Brad F. at https://github.com/bradfitz/http2 (+ https://http2.golang.org) ... is spdy synonymous in the discussions/plans? I am sure Brad's efforts...

Allows limiter headers to be written via setting instead of sending them at all times

Sorry but I don’t understand the request of this ticket.

Cache burst issue

Nope. This package is solid and I use it in prod in many places

Cache burst issue

Good idea, feel free to PR this. Or if you provide the breaking test code, I'll write the solution in httprate

Cache burst issue

solved in https://github.com/go-chi/httprate/pull/20 however, I think exploring an iteration on LimitCounter interface is a good idea too (as mentioned in this ticket)

Allows limiter headers to be written via setting instead of sending them at all times #15

@mwodrich so the request here is to make the response headers with ratelimit info optional? such that, the rate limits aren't returned to the client, and are invisible to clients...?...

Allows limiter headers to be written via setting instead of sending them at all times #15

Indeed, makes sense.

HandlerWithKey:recover panic in callback

Thanks, but in order for me to verify it works I’d need to write a program to try it or a test. Can you provide a test in the PR?