Antoine Pitrou comments

Results 822 comments of


                                            Antoine Pitrou

ARROW-16673: [Java] C data interface: Allow ownership transferring for imported buffer

@lwhite1 Do you feel acquainted enough with the C data interface to give this a look?

ARROW-16673: [Java] C data interface: Allow ownership transferring for imported buffer

Perhaps @lidavidm can give another look? :-)

[C++][DONOTMERGE] Use -O2 instead of -O3 for RELEASE builds

Hmm, perhaps the bit-util micro-benchmarks are a bit pathologic, but other regressions seem real and quite significant...

[C++][DONOTMERGE] Use -O2 instead of -O3 for RELEASE builds

There's `-ftree-vectorize` which apparently enables all vectorization (both "tree" and "SLP").

[C++][DONOTMERGE] Use -O2 instead of -O3 for RELEASE builds

Also, apparently with gcc 12 the following flags are enabled with `-O2`: `-ftree-loop-vectorize -ftree-slp-vectorize -fvect-cost-model=very-cheap`

[C++][DONOTMERGE] Use -O2 instead of -O3 for RELEASE builds

@ursabot please benchmark lang=C++

[C++][DONOTMERGE] Use -O2 instead of -O3 for RELEASE builds

Ok, so I run locally with gcc 9.4.0 (Ubuntu 20.04) on AMD Zen 2. ### Build times (with ccache disabled) * `-O3`: ``` real 1m25,888s user 21m58,527s sys 0m48,888s ```...

[C++][DONOTMERGE] Use -O2 instead of -O3 for RELEASE builds

Hmm, I notice that `-DNDEBUG` was not passed anymore, so perhaps that affected some benchmarks :-( Edit: re-ran benchmarks and updated the gists above.

[C++][DONOTMERGE] Use -O2 instead of -O3 for RELEASE builds

@ursabot please benchmark lang=C++

[C++][DONOTMERGE] Use -O2 instead of -O3 for RELEASE builds

cc @save-buffer @westonpace for further opinions