Antoine Pitrou comments

Results 822 comments of


                                            Antoine Pitrou

[Java][C++] Java VectorSchemaRoot to C++ RecordBatchreader

cc @lidavidm @davisusanibar

ARROW-17306: [C++] Provide an optimized `GetFileInfoGenerator` specialization for `LocalFileSystem`

I'm running this benchmark locally on Ubuntu 20.04, 24-thread CPU, ext4 filesystem on a fast SSD. Out of curiosity I added different dataset sizes into the mix as well as...

ARROW-17306: [C++] Provide an optimized `GetFileInfoGenerator` specialization for `LocalFileSystem`

I'll take a last look here.

ARROW-17338: [Java] The maximum request memory of BaseVariableWidthVector should limit to Integer.MAX_VALUE

Also cc @lwhite1 for review / opinions.

ARROW-17338: [Java] The maximum request memory of BaseVariableWidthVector should limit to Integer.MAX_VALUE

> Is this modification consistent with the goals of https://issues.apache.org/jira/browse/ARROW-6112? I think so. Regular binary/string types have 32-bit signed offsets so cannot handle more than a 2GB data buffer by...

ARROW-17338: [Java] The maximum request memory of BaseVariableWidthVector should limit to Integer.MAX_VALUE

Sorry for the delay @ConeyLiu . Given the several +1's I'm gonna merge if/when CI is green.

ARROW-17290: [C++] Add order-comparisons for numeric scalars

@bkietz Also curious about your opinion on this.

Update Plasma Buffer failed

> When I have updated the arrow::plasma project to support some features in our business. Can you explain what this means exactly? Also, regardless, Plasma is currently unmaintained and will...

ARROW-17259: [C++] Do not use shared_ptr<DataType> with kernel function signatures, do less copying of shared_ptrs

@wesm Would you like to take a look at the compile failures?

ARROW-17259: [C++] Do not use shared_ptr<DataType> with kernel function signatures, do less copying of shared_ptrs

Hmm... I assume it's because of the `serialized_size` difference? It's weird that it would differ by one byte, but perhaps that's due to a different Thrift version. We should probably...