Antoine Pitrou

Results 823 comments of Antoine Pitrou

Hoping to look at this soon - sorry for having forgotten about it.

> The main thing is the Python bindings have an optional dependency on the adbc_driver_manager package, which is not yet released. Is it possible to do a 0.1 release quickly?

> The main thing is the Python bindings have an optional dependency on the adbc_driver_manager package, which is not yet released. This also complicates writing tests for it (maybe we...

I pushed some changes, can you check if they are ok for you @fatemehp ?

For the record, here are the benchmark results here: ``` --------------------------------------------------------------------------------------------------------------------------------- Benchmark Time CPU Iterations UserCounters... --------------------------------------------------------------------------------------------------------------------------------- ColumnReaderSkipInt32/Repetition:0/BatchSize:100/iterations:10 2191628 ns 2190581 ns 10 bytes_per_second=2.17676G/s ColumnReaderSkipInt32/Repetition:0/BatchSize:1000/iterations:10 331052 ns 330886 ns 10...

@fatemehp Is it expected that skipping is slower in most of these micro-benchmarks?

@zeroshade Are you planning to add IPC roundtrip tests for REE?

To be honest, the contract and motivation for `peek()` were always a bit fuzzy, so it's a bit difficult to choose a given semantics. I think the current proposed implementation...

Also, if we were to do it again, we would certainly have `peek()` return a memoryview rather than a bytes object...

> For a new function like BytesIO.peek(), would it make sense to do it? Why not, but it would also deviate from the `BufferedReader` behaviour, which I think defeats the...