arrow icon indicating copy to clipboard operation
arrow copied to clipboard

ARROW-16707 [C++] Implement Rank kernel on chunked arrays

Open WillAyd opened this issue 3 years ago • 2 comments

Initial implementation - could use some guidance on a few points

WillAyd avatar Oct 25 '22 18:10 WillAyd

https://issues.apache.org/jira/browse/ARROW-16707

github-actions[bot] avatar Oct 25 '22 19:10 github-actions[bot]

:warning: Ticket has not been started in JIRA, please click 'Start Progress'.

github-actions[bot] avatar Oct 25 '22 19:10 github-actions[bot]

@pitrou @lidavidm if either of you have time to review would be appreciated as always. I think the CI failures are unrelated

WillAyd avatar Nov 08 '22 18:11 WillAyd

Hey - I'll try to get to this soon but it may be a few more days

lidavidm avatar Nov 10 '22 14:11 lidavidm

Hoping to look at this soon - sorry for having forgotten about it.

pitrou avatar Dec 13 '22 17:12 pitrou

No problem at all - I'll be on vacation the next 5 days anyway so no rush from my end

I'm still not very happy with the copy / paste of the ChunkedArraySort and merge code. I have been concurrently trying a few things with the ArraySort implementation to make that more generalizable just haven't found the right solution yet

WillAyd avatar Dec 13 '22 19:12 WillAyd

Superseded by #33846

WillAyd avatar Jan 25 '23 17:01 WillAyd