arrow icon indicating copy to clipboard operation
arrow copied to clipboard

ARROW-17712: [Go] RLE Array IPC read/write

Open zeroshade opened this issue 3 years ago • 3 comments

zeroshade avatar Sep 23 '22 18:09 zeroshade

CC @zagto

zeroshade avatar Sep 23 '22 18:09 zeroshade

https://issues.apache.org/jira/browse/ARROW-17712

github-actions[bot] avatar Sep 23 '22 18:09 github-actions[bot]

:warning: Ticket has not been started in JIRA, please click 'Start Progress'.

github-actions[bot] avatar Sep 23 '22 18:09 github-actions[bot]

  • Closes: #32949

github-actions[bot] avatar Jan 30 '23 17:01 github-actions[bot]

:warning: GitHub issue #32949 has been automatically assigned in GitHub to PR creator.

github-actions[bot] avatar Jan 30 '23 17:01 github-actions[bot]

CC @felipecrv

zeroshade avatar Jan 30 '23 18:01 zeroshade

@zeroshade Are you planning to add IPC roundtrip tests for REE?

pitrou avatar Jan 31 '23 16:01 pitrou

@pitrou yea, i'm adding IPC roundtrip tests today. well, i'm adding sample run end encoded records to go/arrow/internal/arrdata/arrdata.go so all the tests which use the sample records in arrdata (including IPC roundtrips for both streaming and file) get run-end encoded roundtrip testing.

zeroshade avatar Jan 31 '23 17:01 zeroshade

@pitrou IPC round trips have been added (the tests in ipc/file_test.go and ipc/stream_test.go both loop over the list of test records in arrdata and test a round trip IPC in the file and stream formats respectively for each record.)

zeroshade avatar Jan 31 '23 20:01 zeroshade

I'll merge this EOD if no one has any objections.

zeroshade avatar Feb 06 '23 16:02 zeroshade

Benchmark runs are scheduled for baseline = 9e7b79b37b7db75be7934d59bfdc5e86f21362e8 and contender = 9b4c97242b1964ad42125c23d130ca44652da683. 9b4c97242b1964ad42125c23d130ca44652da683 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. Conbench compare runs links: [Finished :arrow_down:0.0% :arrow_up:0.0%] ec2-t3-xlarge-us-east-2 [Finished :arrow_down:0.37% :arrow_up:0.06%] test-mac-arm [Finished :arrow_down:0.26% :arrow_up:0.0%] ursa-i9-9960x [Finished :arrow_down:0.19% :arrow_up:0.0%] ursa-thinkcentre-m75q Buildkite builds: [Finished] 9b4c9724 ec2-t3-xlarge-us-east-2 [Finished] 9b4c9724 test-mac-arm [Finished] 9b4c9724 ursa-i9-9960x [Finished] 9b4c9724 ursa-thinkcentre-m75q [Finished] 9e7b79b3 ec2-t3-xlarge-us-east-2 [Finished] 9e7b79b3 test-mac-arm [Finished] 9e7b79b3 ursa-i9-9960x [Finished] 9e7b79b3 ursa-thinkcentre-m75q Supported benchmarks: ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True test-mac-arm: Supported benchmark langs: C++, Python, R ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

ursabot avatar Feb 07 '23 06:02 ursabot