Matthew Zipkin

Thanks again @vasild rebased on master - I see some new I2P tests in there now! Had to update those with the changes to `CreateSock()`

Rebased on master to fix silent conflict with new I2P tests. @maflcko thanks. Can you help me understand why this only broke the previous builds task?

@Sjors https://github.com/bitcoin/bitcoin/pull/27375#discussion_r1506062696 > Both call sites of ConnectThroughProxy have access to conn_type so might as well pass in manual_connection. Do you mean to pass it `ConnectThroughProxy()` -> `proxy.Connect()` -> `ConnectDirectly()`?...

@Sjors If I'm following this correctly, the only benefit of passing `manual_connection` to `ConnectDirectly()` is that it is then passed to `ConnectToSocket()` which only uses the boolean when logging with...

`git range-diff master 6dddc1c2eda514d35219cce03c229bd6f822be55 567cec9a05e1261e955535f734826b12341684b6` Rebased on master to fix conflicts and ( 🤞 ) pass CI. @Sjors thank you so much for the review, I addressed all your nits...

> Oh! The test command I use doesn't rerun autogen.sh every time, I think that's what caused the test failure. @pinheadmz You can reset the branch back to [567cec9](https://github.com/bitcoin/bitcoin/commit/567cec9a05e1261e955535f734826b12341684b6) and...

Still waiting for CI to finish but I removed the need for internet access by looking up the name `"localhost"` instead. That is a non-numeric lookup that `getaddrinfo()` can do...

added call to `thread.join()` in the "happy path" so the only threads we should be abandoning are those that time out. Also setup the unit test to stub in a...

...got thread sanitizer errors running locally on main when my local DNS is black-holed. Fixed that with a shared pointer.

> Needs rebase? ty. 🤞