Matthew Zipkin

Results 715 comments of Matthew Zipkin

> 🐙 This pull request conflicts with the target branch and [needs rebase](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#rebasing-changes). Relax bot! sheesh. I'm gonna wait until #27375 gets approved

> There hasn't been much activity lately and the patch still needs rebase. What is the status here? Waiting for https://github.com/bitcoin/bitcoin/pull/27375

Rebasing on master since one commit was merged separately in #29649

Thanks so much for your review @laanwj addressed your comments

Great catch! To summarize, the RPC is returning an extended PUBLIC key followed by a hardened derivation path. Which is not usable.

concept ACK 6fad02cf03 (code review in progress) I am also testing this feature in Warnet, which deploys a regtest network and even has an internal Tor DA so I can...

> Is this going to be on by default or just an option? This PR only affects transactions sent with RPC `sendrawtransaction` and only if `-privatebroadcast=1` is configured, which is...

> 1. Example URL: [https://bitcoincore.org∕bin∕bitcoin-core-27.0∕@bitcoin-27.0-win64.zip](https://bitcoincore.org%E2%88%95bin%E2%88%95bitcoin-core-27.0%E2%88%[email protected]) The @ is pretty obvious to me. But regardless what can bitcoin core do to protect users who download software from links they find anywhere...

If we change the name of the file, I think we should also include a dummy-proof instruction to *remove* `.example` when deploying the file, here: https://github.com/bitcoin/bitcoin/blob/67c0d93982ad214f5e0c9509e9dc3d6d792ad97c/contrib/devtools/gen-bitcoin-conf.sh#L40-L42