Matthew Zipkin

Results 708 comments of Matthew Zipkin

I found another edge case in libevent regarding URI handling, it does not decode `%XX` characters before parsing. This is in libevent's `evhttp_uri_parse()` which is called by Bitcoin's `GetQueryParameterFromUri()` Example,...

@pablomartin4btc thanks, I added this test to my branch: ```cpp // Multiple parameters, some characters encoded uri = "/rest/endpoint/someresource.json?p1=v1%20&p2=100%25"; BOOST_CHECK_EQUAL(GetQueryParameterFromUri(uri.c_str(), "p1").value(), "v1 "); BOOST_CHECK_EQUAL(GetQueryParameterFromUri(uri.c_str(), "p2").value(), "100%"); ``` You're totally right,...

Test worked for me on mac and failed as expected without 1.1.1.1 and 2.2.2.2 On my system the command was `ifconfig en0 alias 1.1.1.1`

If @b-l-u-e is going to retouch to update the instructions in the test comment I'd also really like to see those instructions executed in a CI test as well.

Do we use type checking for any configuration argument? I just noticed i could start bitcoind with `-prune=pancakes` with no errors: also no idea what the prune limit would actually...

Sync progress as reported by Bitcoin Core is really only accurate up to the height of the chain at the time of release. The number of transactions in the blockchain...

> Are you implying that block production can vary by as much as 11% from predicted rates in 3 years? It's about total number of transactions. Created by humans. Very...

Concept ACK This looks great and the API in the header looks easy, thanks. I'm in the process of cleaning up my HTTP branch for a pull request and then...

Something else I see using Sockman is in the `mempool_limit` functional test, we call `getrawtransaction` and expect around 540,000 bytes back. The call to `send()` returns the total amount of...

@luke-jr can you rephrase your comment in a friendlier way please