Matthew Zipkin

Results 709 comments of Matthew Zipkin

Would this change need a `release-notes-27064.md` file? It is kinda changing a configuration model

Push to 60cd07b781bfe46262a5d66c97e257e0dd378f5c: - rebase on master - add PR release note - change how we detect "old" directory use from looking for `blocks/` to looking for `chainstate/`

> This change ignores non-main network data. Ah I see, because I'm checking for `Bitcoin\chainstate` specifically but if a user only ever used signet, there would be a nested `signet`...

> Why would we prefer local over roaming explicitly? From https://www.makeuseof.com/tag/appdata-roaming-vs-local/ > In the end, Roaming and Local are functionally identical for a home PC running Windows. In a domain...

> I think we should check for existence of `Roaming\Bitcoin` rather than any subdirectory. revised, rebased on master and pushed thanks. I tested this "in production" on my windows laptop...

> Could rebase for fresh CI, if still relevant? rebased on master

@hebasto thanks for the review, I addressed your comments

@Riahiamirreza are you still working on this?

There are some hints in `test/rpc_createmultisig.py` and probably a few other tests as well. I also tried to create a P2SH multisig and spend from it manually on regtest, it...

> Why not pass the details in `m_debug_message` and add that as a new field? My thinking was to match exactly the single combined string returned by `sendrawtransaction`. But if...