Matthew Zipkin

Results 683 comments of Matthew Zipkin
trafficstars

> 🐙 This pull request conflicts with the target branch and [needs rebase](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#rebasing-changes). done ✅

> If this is done I think we could merge everything except the last two commits in a separate PR, and start having better test coverage in master right away....

@ryanofsky separate tests PR is ready for review: https://github.com/bitcoin/bitcoin/pull/27850

Rebased on master now that #27850 is merged. This PR becomes very slim, one line of code changed and switching the test from expected fail to expected pass.

> Should squash the two commits so that there isn't a commit for which the CI fails. done thanks

Rebased on master to fix conflicts and address test changes in the followup https://github.com/bitcoin/bitcoin/pull/28660 Might be good to get review from @TheCharlatan because this PR touches code just updated in...

Thanks for the reviews, @mzumsande @furszy @pablomartin4btc @LarryRuane I just rebased on master to clean up CI

This PR probably closes https://github.com/bitcoin/bitcoin/issues/8106

@willcl-ark thanks, I added comments and release notes. I also wrote a tiny testing package using [libjson-rpc-cpp](https://github.com/cinemast/libjson-rpc-cpp) to check against an "outside" JSON-RPC 2.0 implementation. The package is https://github.com/pinheadmz/jsonrpc-bitcoin and...

This PR is ready for code review if any of you fine handsome concept-ACKers have the time ❤️