Matthew Zipkin

ACK 4275195606e6f42466d9a8ef766b3035833df4d5 Show Signature ``` -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 ACK 4275195606e6f42466d9a8ef766b3035833df4d5 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmPmX4QACgkQ5+KYS2KJ yTp9Qg/8DS+6sPz95i2whVHQhnphYYAbbF68udZnle8PqeKof7lWGHOnCF3our+/ m2oOGfwXdviYMtIJzB+qBpwRHWonJStIl90Tz6yWqwnM2H5djWhpRBKUsjXMSPsI vpFJCL2eQNSohNcBJ3aG2rZ3SIrMRZaFBiC1cKKan5XYbZBistXFg5H7odmTTwa/ j70qkh3dK+NINELUC5Q+exVSPK9LSwH8tmfIKjd0mb0RL7ABXISEVEQSjkdIgOG9 tNFc9o3Nlcseyha0V7bzkDEL0cSPoxInbxlUHv/o8+6+XnPL3cn2hGrFy424OMg6 IvZeiQacQbaHzDjDNI9bcK4nyunLqPz1G3r53ibs2CU507Mfv/TNIoToFyJzg/HF kgb9qRhg/KwqaZ/2bT4OatAOja+t8lnFMvVL0NB0Uhmudv1kbcGERqIQWc8/0dru 17vdbiu3YqAstDMhtndvy/hupEuBEqEc97xNmXu9xmB8TP9FKDpRS2qWWpvbQNna 7gh49R+eBu/0kxeMhIrc2oXL1S3oaVH1kNqYwGT6cM7Qvt1nVJgGohm2JCE9PuPf Md+VcMm/EhQwUjl7Ja58Sv3UdkWMmQKFj/DhVowJHht4tfDPtl6hR6iBitnB3/69 aoh/KBaiey/cSOXVv7zX5TQv21452+fdDuZPjFeGPct+vHxf/II= =r6pu -----END...

concept ACK verified scripted-diff @MarcoFalke once this change is merged, is there any need to keep `copyright_header.py` at all any more?

concept ACK great work! I can't think of anything to add or change

Rebased on master and prepended an extra commit with a unit test for BlockManager. The test passes on master and the branch without modification, hopefully illustrating that at least some...

force-push to e600eb442802ca7b23189c8ceee448730e22e75a: - rebased on master and fixed conflict - added 2-second sleep before calls to `SaveBlockToDisk()`. This is to ensure that if the file is modified, its modification...

force-push to b4ce309ef5f2bed5ed1f861305317a0dca3dc5f4: - addressed all nits and review comments by @LarryRuane - added 1ms delay in blockmanager test for all non-windows systems (cc: @mzumsande )

> consider the suggestion for the unit test commit comment here: [#27039 (review)](https://github.com/bitcoin/bitcoin/pull/27039#pullrequestreview-1320666918) (I think you may have just missed it), but it's not important. ah doh! I added a...

force push to: 93c70287a6434c6c665a211dc4dfbbd9c3db4083 - rebase on master - fix failing unit test

Ok I updated the unit test: removed the time modified checks because all we need to check is if the content of the file has been changed, which it is...

> Maybe rebase to make CI less sad? rebased. cheer up little guy!