Matthew Zipkin

@cbergqvist thanks so much for your thorough review! ---- re: Implicit version Yes the default 1.1 parameter in cpp code is to keep default behavior from bitcoin-cli. In python it's...

@ryanofsky thanks so much, again, for your help. Especially in understanding the `std::move` semantics. I've reviewed each commit in your branch and force pushed it to mine with the only...

force push to cbc6c440e3: - rename enum to `JSONRPCVersion::{V1_LEGACY, V2}` - use `std::move()` in httprpc - pass `catch_errors` argument to `JSONRPCExec()` - replace `RPC_PARSE_ERROR` with `RPC_MISC_ERROR` in `JSONRPCExec()` thanks again...

Are you referring to the file https://github.com/bitcoin/bitcoin/blob/26.x/share/examples/bitcoin.conf ? Which includes the preface: ``` ## All possible configuration options are provided. To use, copy this file ## to your data directory...

Ok I don't agree that that would be an improvement, because: 1. The path already contains the word "example" (`examples/bitcoin.conf`) 2. Changing that file's name would also require an additional...

Aha ok sorry I misunderstood, you were referring to the release packages not the source code repo. Still I think the instructions in the header are clear. However it does...

> IMO folks looking for an example conf would also be more likely to look for and find it in `share/`. agreed. im testing your commit in a guix build...

After catching up on the discussion in #29903 my opinion now is that we close this issue and the pull request. The bitcoin.conf file is self-documented and the datadir location...

General question about this: what will be the impact on tor/i2p nodes? (Like, resources-wise for those operators) are there even enough hidden services nodes with inbound slots to support this?...

oh one more thing! probably should add a release note :-)