Matthew Zipkin
Matthew Zipkin
Added a scripted-diff to completely replace all occurrences of the application-defined `RPC_INVALID_PARAMETER` (-8) with the JSONRPC 2.0 spec-defined `RPC_INVALID_PARAMS` (-32602)
> 🐙 This pull request conflicts with the target branch and [needs rebase](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#rebasing-changes). done, very easy with scripted diff!
> 🐙 This pull request conflicts with the target branch and [needs rebase](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#rebasing-changes). 👌
@achow101 I added `IsNotification()` and a test. Also rebased the PR with more atomic commits for hopefully easier reviewing. As far as 500, that should only be returned by a...
Rebased on master to re-apply scripted diff
also rebased on master again to apply scripted diff
@vincenzopalazzo great point thanks, I'll chop off the scripted diff and rebase on master. It has been annoying to keep that scripted diff up to date anyway
Thanks @ryanofsky for the thorough review. I was misunderstanding the different roles of `httprpc` and `server` and I think tiptoeing around minimal commits when more changes were needed to really...
@ryanofsky thanks again for thorough review. I addressed all your comments. The one commit I am not fully confident in is 50debf781dbc4ac73cd1c0138ed9d405ea60eacb "rpc: use move semantics in JSONRPCReplyObj()" which is...
Thanks for your fantastic in-depth review, @tdb3. I force-pushed to 58cb22c83c This addresses the two discrepancies you caught in your actions 1 & 2: - Empty batch requests are no...