Steve Pieper

Results 541 comments of Steve Pieper
trafficstars

I think this is looking good - just a lint issue https://github.com/Slicer/ExtensionsIndex/actions/runs/9089156174/job/24997747489?pr=2030 any more suggestions @lassoan ?

I'd be okay with merging and sorting out any remaining issues in the context of preview builds.

@jcfr @lassoan any comments?

Does this extension build C-GAL? If so I understand that would make the extension GPL.

Thanks for the clarification @CharlesGueunet . As a rule we don't rely on GPL code for Slicer application (e.g. [see this discussion](https://discourse.slicer.org/t/rpy2-pip-installation-fails/4883/14?u=pieper)). Is there a way the GPL code could...

The Clipper2 option sounds worth exploring. If it works well enough, a clean new implementation would be way better than perpetuating a GPL'd codebase with nightmare build systems. I agree...

@zhangfanmark thanks for putting this together. Please do go through the checklist in this template and perform the steps. It may seem like a lot but they should be quick...

Thanks Fan 👍 If Kening has any questions at all, let us know.

Hi Kening - The license is good and the image looks nice so thanks for the update. What we were looking for is the items on the checklist at the...

> This would be very nice. I might need some hints on how to implement this @pieper. here's a similar script: https://gist.github.com/pieper/17cf79b8ea852693bde0b63bafbaa74f Regarding existing SlicerFreeSurfer, I think this makes sense...