Damian Pieczynski

Results 116 comments of Damian Pieczynski

Hi, manage to create a workaround for yarn3 using a custom plugin, till #612 First in `netlify.toml` use `NPM_FLAGS` hack to disable default npm install, here we cannot use `NETLIFY_USE_YARN`...

Hi, checked the PR and looks like better if we push this logic to adapters, as we can't know how the options are set there. With this change on react...

btw, till we fix this, one hack for react adapter can be ```tsx const virtualizer = useVirtualizer({ count: dataCount, getScrollElement: () => parentRef.current, estimateSize: () => 50, }); const virtualizerRef...

@francislavoie yes, basic we don't want to have virtualizer as dep in that effect. It should be well know pattern by now in react community, but if someone don't know...

@christiankaindl on other hand, more robust would be as you did to call the calculateRange when options change, but not for every call of setOptions. Something like https://github.com/TanStack/virtual/compare/beta...piecyk:fix/calculate-range Here we...

> Then the only question is, if having to use useCallback() is acceptable API wise (it was like this in v2.x as well)? I think it's fine, what do you...

Yeah, here we need to add something like `scrollMargin` that will handle this cases. @dylanwulf was on right path, internally we need to skip altering scrollToFn when syncing scroll position.

@wuarmin here we have couple of issues, overall we calc the position of each row base of previous one, when we don't know the real size we estimate it, via...

> Interesting solution with embedding a new React tree, but I think that would have the issue of being unable to navigate the root BrowserRouter from within the nested React...