Damian Pieczynski
Damian Pieczynski
Thanks @garrettld for this awesome work, i think we are fine with the angular-virtual. Please sync with main and fix the lock file.
'use no memo' seems like a reasonable temporary workaround! https://react.dev/learn/react-compiler#something-is-not-working-after-compilation
Thanks @iscekic for reporting the issue! I haven’t checked it yet, but it seems related to the loosened approxEqual logic introduced in https://github.com/TanStack/virtual/commit/60719f61b589d6f9d886e4f7c093217f6d693faf
@beliarh That makes a lot of sense, thanks for the detailed breakdown. I’ll try to look into it as soon as possible.
Hey I’ve opened a PR that fix scrollToIndex behavior https://github.com/TanStack/virtual/pull/1029 If you're interested feel free to take a look and test it out! Feedback welcome.
Can be tested via https://github.com/TanStack/virtual/pull/1029#issuecomment-3008435705 without waiting for it to be merged and published.
Just released [@tanstack/[email protected]](https://github.com/TanStack/virtual/releases/tag/%40tanstack%2Freact-virtual%403.13.12) should fix the scrolling issue.
@st-manhle Hmm, so just to clarify, you're calling scrollToOffset to scroll to the bottom, but then the items expand in height and the scroll no longer sticks to the bottom?...
Thanks for reporting this! I’ll have a look into this issue soon and see if I can figure out what’s going on. In the meantime, if anyone else has insights...
Thanks for reporting this! I’ll check into the issue soon and see what can be done to improve the performance. Appreciate your patience!