reagent-template icon indicating copy to clipboard operation
reagent-template copied to clipboard

add http-kit profile

Open yogthos opened this issue 9 years ago • 11 comments

yogthos avatar Mar 23 '15 17:03 yogthos

:+1:

piecyk avatar Mar 27 '15 15:03 piecyk

i took a basic reagent-template app and modified it to work with aleph/manifold... which probably satisfies the same itch you are looking for http-kit to scratch (async, websockets) ?

https://github.com/mccraigmccraig/sparky-elephants

the aleph server doesn't support the :auto-reload? option so i added a ring handler based auto-reload solution :

https://github.com/mccraigmccraig/sparky-elephants/blob/master/env/dev/clj/sparky_elephants/repl.clj

i could port the changes back to an aleph profile in the reagent-template project if you are interested ?

mccraigmccraig avatar Apr 30 '15 14:04 mccraigmccraig

there's actually an easier way, you can use ring.middleware.reload as I'm doing in Luminus here.

yogthos avatar Apr 30 '15 14:04 yogthos

hmm, iirc i had problems with ring.middleware.reload not re-creating the handler chain, so i modified ring.middleware.reload ( https://github.com/mccraigmccraig/sparky-elephants/blob/master/env/dev/clj/sparky_elephants/wrap_reload.clj ) and then recreate the handler chain on each request

mccraigmccraig avatar Apr 30 '15 15:04 mccraigmccraig

anyway, sounds like you don't need any help with aleph ;)

mccraigmccraig avatar Apr 30 '15 15:04 mccraigmccraig

Ah yes I've noticed that as well, route modifications don't get reflected either. I wouldn't mind adding aleph profile as well, just need time. :)

yogthos avatar Apr 30 '15 15:04 yogthos

if you would take a PR, i could do an aleph profile in the next few weeks ?

mccraigmccraig avatar Apr 30 '15 15:04 mccraigmccraig

that would be fantastic :+1:

yogthos avatar Apr 30 '15 15:04 yogthos

cool, i'll get on it when i have a moment :)

mccraigmccraig avatar Apr 30 '15 15:04 mccraigmccraig

@mccraigmccraig so have you had a moment since 2015 ?) Does somebody actually interested in this staff ?

alehatsman avatar Apr 26 '17 06:04 alehatsman

@Atsman i haven't! i only went and started a new company 😬

mccraigmccraig avatar Apr 26 '17 09:04 mccraigmccraig