Marc Pichler
Marc Pichler
As far as I can tell, most of the points this PR addresses are already done and it would be a pain to rebase this. From what I can see...
Hi @srikanthccv :slightly_smiling_face: Friendly question: are you still planning to work on this? :thinking: Otherwise I'll mark this as up-for-grabs in case someone else has some cycles to work on...
Hmm, I wonder if we should add an optional `updateMetricInstruments()` to `InstrumentationAbstract` that is called when `setMeterProvider()` is called. I feel like I don't know enough about the instrumentations to...
Just went through the code and saw that the following env-vars from [this spec](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md) are also not implemented right now: - `OTEL_EXPORTER_OTLP_METRICS_COMPRESSION` (currently the trace setting is used instead) -...
Thank you for pointing this out. I'll pick this up ASAP. :slightly_smiling_face:
@weyert thanks for adding this and taking the time to switch over the tests. :rocket: I marked the PR as draft now, you should be able to mark it as...
Looking good, thanks for adapting the tests. :slightly_smiling_face: I think this should be ready once the linting errors are addressed (there are a few unused imports and missing semicolons). :slightly_smiling_face:
I'll self assign and work on this :slightly_smiling_face:
I've been looking into the code in a bit more detail regarding your questions @svetlanabrennan :slightly_smiling_face: As far as I can see, we could override the `register()` method in the...
Most recent failure seems to be related to #3238 (let's see if a re-run helps in the meantime to get this unblocked :slightly_smiling_face:)