Marc Pichler

So I asked around a bit what the original intent of that hook was: it's original intention was for users to be able to apply header values to their spans...

Closing this PR based on the reasons mentioned above. As a workaround please use the other option (manually creating a span when handling the body and attaching the necessary data...

Hi @naorpeled, thanks for reaching out :slightly_smiling_face: there's currently an open PR that will add that feature to the winston instrumentation: - https://github.com/open-telemetry/opentelemetry-js-contrib/pull/1837 - it adds a winston transport which...

AFAIK this is not something we generate. I've never seen it.

> it is hard coded in the optljs_agave.js file. if used and then a security scan is run, it picks up the name states "key" and has a hard code...

I'm closing this for now due to no response. For additional questions please open another issue.

Hmm, AFAIK this is something we do in the base class. :thinking: There are also tests for this behavior: https://github.com/open-telemetry/opentelemetry-js/blob/4655895ba1a3b62d4031b6ef0ddf52c63f611d0c/experimental/packages/exporter-trace-otlp-http/test/node/CollectorTraceExporter.test.ts#L180-L199

Ah interesting, I think this is a bug. :bug: It should actually never allow you override the `User-Agent` header at all. At least that's how we interpreted this section of...

I can't believe I missed this when reviewing the recent PRs. [Here](https://github.com/open-telemetry/opentelemetry-js/blob/4655895ba1a3b62d4031b6ef0ddf52c63f611d0c/experimental/packages/exporter-trace-otlp-http/src/platform/node/OTLPTraceExporter.ts#L48C10-L48C20), `USER_AGENT` should be the last thing we add so that it overrides whatever the user passes in.

> We don't think a full override should be available but the possibility to add a prefix to include info about the distribution would come handy so it easy fir...