Pierre Goiffon

Hello, Dev team reviewed this : as this is a change with very few benefits we are asking that a test covers modified code to ensure no regression is introduced.

Did you test database migration ?

> I also think the ITSM connectors also require this consent. For now it isn't. I suppose it is because if you have a package including the ITSM Designer Connector...

> For a private function, it is perfectly doable to do a refactoring to correct english naming: > > ``` > private function NeedsGdprConsent() > ``` Yeah, we should do...

I've done the rename directly in this PR branch as it will lower the possible conflicts :)

Rebased (there were conflicts due to #335) and forced pushed !

Discussed during the technical review today. Ok to merge, but : - we need to rebase on support/2.7 first ! - also check the phpunit XML and advise when to...

Rebased on support/2.7 and forced pushed Warning @rquetiez you'll need to destroy your local branch and ref and checkout again from origin !

About phpunit xml : the added test is in test/setup/ModelFactoryTest.php, and this directory is indeed included in test/phpunit.xml.dist. The whole test class takes 277ms to process on my laptop, so...

@rquetiez on \Combodo\iTop\Test\UnitTest\Core\ModelFactoryTest::testAlterationsByAPIs I've got an error on the `@covers \MFElement::GetDelta` phpdoc : > [EA] @covers referencing to a non-existing entity '\MFElement::GetDelta' I don't see any call to this method...