GDPR consent : apply to all instances containing the Hub connector

[xtophe38]

Up to now, we define that RGPD consent is required if iTop is not an "iTop Product". This is, I think, too restrictive as other products based on iTop (TeemIp std alone today and ESM products tomorrow) may not require RGPD consent even if they are not "iTop Products". Since instance data are collected through iTop Hub only, I suggest to base the test of RGPD consent requirement on the fact that iTop Hub Connector extension is installed.

[Hipska]

I also think the ITSM connectors also require this consent.

PS, the correct English term is GDPR.

[piRGoif]

I also think the ITSM connectors also require this consent.

For now it isn't. I suppose it is because if you have a package including the ITSM Designer Connector then you have a contract with Combodo or one of its partner ?

@dcoille can you confirm ?

[Molkobain]

I like your suggestion ! Just a little change request : you should create a SetupUtils method, as what was done with IsProductVersion. To test for the presence of the Hub Connector, maybe call it IsItopHubInstance ?

Like Pierre I would rather have the test using a detection method than an "hard-coded" test, so we can factorize this kind of detections.

[xtophe38]

Factorization done as required.

[Hipska]

For a private function, it is perfectly doable to do a refactoring to correct english naming:

	private function NeedsGdprConsent()

[piRGoif]

For a private function, it is perfectly doable to do a refactoring to correct english naming:

	private function NeedsGdprConsent()

Yeah, we should do that, but it won't be mandatory for this PR to be accepted. I'll do the rename :)

[Hipska]

Sure, it can be accepted as is indeed. I was just mentioning as it could be done in this PR as well, no need for a separate PR.

Or, indeed, just do it directly on the branch without PR, that works as well 😄

[piRGoif]

I've done the rename directly in this PR branch as it will lower the possible conflicts :)

[Molkobain]

Functional review: R&D still to do some checks but it is accepted. If chosen implementation is very safe plan for 2.7.8, otherwise 3.0.3

@Hipska there is no GDPR disclaimer for products using the ITSM Designer because they can only be used with a Combodo subscription which contains the legal details.

[piRGoif]

Rebased (there were conflicts due to #335) and forced pushed !

[Molkobain]

Moved to functional review to avoid loosing another month while function is renamed

[Molkobain]

@xtophe38 once method changed, it's ok to merge

[piRGoif]

Rebased & force pushed