Pierre Goiffon

Results 132 comments of Pierre Goiffon

Hello, I'm really sorry, it took me a while to take a look. I just began writing a test, I saw your branch is based on support/2.7 (2d156bd7). I'll change...

Test pushed ! PR is ready for next technical review (should happen next month)

Discussed during technical review : we'll have to deep dive into this, cause this might not be the better way to solve the issue. Actually the 2 DBSearch still exists...

Hello, We took some time to discuss the issue with @rquetiez and @eespie Renaming the params is a workaround, this behavior is a real bug... We would like to dive...

Hello, Not sure of what problem you are trying to solve ? Can you attach a use case, maybe your XML customization as a gist, and a step by step...

Oh, also I see you based on support/2.7 : this is not a good idea (as said in our CONTRIBUTING.md), I highly doubt we will integrate your work in a...

Sorry, I was very busy last weeks. Thanks for all the explanations, I understand better what you are trying to do. Obviously modifying iTop core files (like \UserRightsAddOnAPI::MakeSelectFilter) isn't a...

Hello, Thanks for the PR ! `AttributeClass` was created a long time ago, I think before XML customization was added. This was certainly forgotten when XML was added as a...

> could you in the meantime make sure the attribute is described in the documentations? Documenting or not will be decided during the functional review of this PR.