Pierre Goiffon
Pierre Goiffon
Person.tickets_list For now we are generating this query : ``` SELECT `Ticket` FROM Ticket AS `Ticket` JOIN Person AS `Person` ON `Ticket`.caller_id = `Person`.id WHERE (`Person`.`id` = :id) ``` instead...
n-n attributes : same as before, this is done using the same means in \AttributeLinkedSet::GetDefaultValue (no impl in the child class AttributeLinkedSetIndirect, but in this impl we have a test...
Discussed with Romain about the DBSearch generation in \AttributeLinkedSet::GetDefaultValue : - this was like this from the very start (see b756db09 in... 2009 !!!) - browsing the code history, we...
Discussed during technical review today. Romain and Anne-Catherine will do a pre-review together. In particular we need to be sure : - where is this \MetaModel::PurgeData mehod used in iTop...
Hello Vladimir, thanks for this contribution ! I applied this XML to a standard iTop on the develop branch : ```xml self tree ``` And easily reproduced the problem, thanks...
Indeed, there were quite a few remaining uses of the attribute with the "self" keyword. I've changed them in 8640918d Thanks !
The Email class was totally refactored in iTop 2.7.7 : * eb1d56f43942b3f49275005073919a701f13d109 * 754946bf62fcc9f62ddaf8120951b6c6127001e1 * 622f40c06cf9d3dbe170416498c4906dd1314318 Rebasing this branch cannot be done anymore. I'm closing this PR and opening a...
Now that I finished the new PR, yes :)
During technical review, we wanted to see if it was possible not to call Debug() method when the level isn't enabled. Indeed it is... but starting from 3.0.0 only :/...
Discussed during technical review ! We agreed to change the log level : use Error instead of Debug Ideally we could replace the placeholder with the error message, but that...