Pierre Goiffon

Results 132 comments of Pierre Goiffon

Very nice idea, OK for me ! I would maybe prefer "binary data", as "blob" is more of an implementation detail ? Can you change it before the review on...

Oh, I didn't knew `Core:AttributeBlob` : you're right, it's better to use it ! Sorry :/ Can you do this last change ?

> These two are not dependant on each other.. It was already possible to sync binary data by directly connecting the datasynchro tables.. Well, I think Guillaume meant that we...

Yes it's really dirty :( We'll have a chat with the rest of the dev team, I might have missed something obvious. At least we could add some ContextTag...

About formatting, well, this is not easy for a file like this, as I needed to add lines in a non well formatted switch case... I could have done better...

I had a quick chat with v-dumas : a possible Combodo's internal ref is N°3200. We will discuss face to face next week on this subject :)

Dev team reviewed this PR. Conclusion : * [x] no emoji in the menu items as the rendering will be platform dependent, we should rather use Font Awesome icons, and...

> I see that the same URL already is generated and is available as `$sURL`: I'll have a look, thanks !

Reviewed this today with @v-dumas. Conclusions : * [x] remove emoji indeed, but don't use FA icons yet (this will be subject of another FAF maybe, there are multiples issues...