Pooya Parsa comments

Results 2282 comments of


                                            Pooya Parsa

To include contributor's avatar property to /repos/{owner}/{name}/contributors

Avatars are linkable as `https://github.com/{username}.png` ([example](https://github.com/claytonchew.png)). Have you tried it?

refactor!: replace execa with tinyexec

Thanks for PR. I think so we might directly use `node:child_process`. Nypm was doing this before. We moved to execa to support cross-platform search path of `corepack` mainly (https://github.com/unjs/nypm/pull/54). However...

feat(session): allow replace instead of update

Thanks for the PR. I think instead of introducing a new `replaceSession` method, we can introduce a new 3rd arg `replace: true` to allow replacing it.

Improve type safety in `useSession` by using `Partial` for `SessionData`

Can you please elaborate more in which cases it can be beneficial? (a code repo example would be nice)

Improve type safety in `useSession` by using `Partial` for `SessionData`

Thanks for explaining. Types will be partial in h3 v2.

[BUG] Publishing Github release doesn't work in v0.5.2

This seems (always was) a bug when only setting provider without github URL. Can you try removing `repo` configuration and instead set `repository` field in your `package.json`

[feature] Can a cache clearing interface be added?

Since currently we rely on single token and there is no protection mechanism, this can be easily abused. I think we can extend #5 idea to allow adding tokens specific...

Relative URL replacement breaks links to directories

Hey thanks for the detailed issue. I'm little bit occupied to check this more in details, but just a quick idea, maybe wn limit rewrite of #52 to assets(images) which...

Use `process.getBuiltinModule` for hybrid node modules

You are right @IgorMinar we will bundle polyfills that's the inevitable cost if we do this for other benefits (still bundlers can tree-shake per export - not per module that...

Use `process.getBuiltinModule` for hybrid node modules

> If workerd has a problematic native implementation, we won't be able to override it in unenv (shouldn't happen, so maybe not a problem?) If workerd have a known issue,...