Pooya Parsa comments

Results 2282 comments of


                                            Pooya Parsa

Use `process.getBuiltinModule` for hybrid node modules

Thanks for sharing your thoughts @IgorMinar. Let's stay with the current approach (unenv-bundled-by-usage) for wrangler tooling, considering the current system works for you and the announced date is close, we...

feat(loader): scan for config keys files

Thanks for PR. Some changes: - I think we should this convention opt-in - We should use `readDir` that reads exactly one level (not nested), we might support more levels...

implement base64url in buffer by switching to js-base64

@huseeiin any specific reason you haven't gone with Deno stdlib implementation as your original idea? checking, it seems this lib has extra polyfills for legacy env without atob support which...

Replace corepack with an integrated solution

We want to nypm work as a JS library without additional dependencies need to be installed by users, otherwise corepack and other native version managers are really good solutions (for...

Install dependencies after cloning not working with pnpm-workspace

Hi dear @Callan003 thanks for the nice reproduction and sorry for delay on this. I have made upstream issue in nypm that handles downloading which by default it probably has...

fix: relative link replacement

Unit test would be nice! (also good for later refactors to move to an AST aware transform)

fix: relative link replacement

I don't have enough bandwidth to check on ungh PRs in the upcoming weeks (at least until Nitro v3 is out) Sorry

feat: mergeStrategy

Thanks for this PR. I had been thinking about how to generalize feature and came up with idea in https://github.com/unjs/c12/issues/145. If you are happy to reiterate towards more generic approach.

feat: mergeStrategy

Let's generalize it as simple merger fn ~> https://github.com/unjs/c12/pull/160

Consider supporting multiple scoped env files

@michael-bouvy ~> https://github.com/unjs/nitro/issues/1079