h3 icon indicating copy to clipboard operation
h3 copied to clipboard

feat(session): allow replace instead of update

Open remonke opened this issue 1 year ago • 2 comments

#773

remonke avatar Jun 14 '24 06:06 remonke

Codecov Report

Attention: Patch coverage is 81.81818% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.78%. Comparing base (a58d7c9) to head (4b630ea). Report is 190 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/session.ts 81.81% 6 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #774      +/-   ##
==========================================
+ Coverage   77.83%   79.78%   +1.95%     
==========================================
  Files          47       53       +6     
  Lines        4286     5324    +1038     
  Branches      611      676      +65     
==========================================
+ Hits         3336     4248     +912     
- Misses        933     1058     +125     
- Partials       17       18       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 14 '24 06:06 codecov[bot]

Thanks for the PR. I think instead of introducing a new replaceSession method, we can introduce a new 3rd arg replace: true to allow replacing it.

pi0 avatar Jun 17 '24 12:06 pi0