Philippe Scorsolini
Philippe Scorsolini
If this was about initial creation, this is due to the fact that we recompute every time the generated name for the failing composed resource and update the XR's `resourceRefs`...
To recap: - the function composer always errored out when trying to apply invalid resources, preventing successive resources from being applied AFAICT - the pt composer in 1.13 used to...
A little more details before I forget, at least this is what I understood. In 1.13 we were only dry-running the first [time](https://github.com/crossplane/crossplane/blob/01c5d2b0308e775e2043f9552631037c23ceaed8/internal/controller/apiextensions/composite/composition_pt.go#L562), [marking](https://github.com/crossplane/crossplane/blob/01c5d2b0308e775e2043f9552631037c23ceaed8/internal/controller/apiextensions/composite/composition_pt.go#L217) resources as having an error, and...
Here an example: XRD and compositions ```yaml apiVersion: apiextensions.crossplane.io/v1 kind: CompositeResourceDefinition metadata: name: xparents.example.org spec: defaultCompositionRef: name: parent group: example.org names: kind: XParent plural: xparents claimNames: kind: Parent plural: parents...
If I got it correctly this would address https://github.com/crossplane/crossplane/issues/5114 too
I now noticed we also marked as not ready a resource [here](https://github.com/crossplane/crossplane/pull/5365/files#diff-574bed872a28203735722ddf7a98e52ad596702e555ed0dda6525e4e578481f2L301), which per the original 1.14 implementation was a code path we got into when the resource didn't dry-run...