Philippe Scorsolini

Results 221 comments of Philippe Scorsolini

Depending on the decision taken by https://github.com/cloudnative-pg/cloudnative-pg/issues/3697 we could be fine with the full CRD for the pooler too here.

@achanda, as you can see we agreed to use server-side apply for CRDs: https://github.com/cloudnative-pg/cloudnative-pg/pull/3729 This means here we can have the full schema produced, could you revert the last commit?...

Yes, I think they are too, I'll let the second reviewer decide if they want to run them again or just mark it as good to go straight away 👍

Looks like we have a valid approach and given the number of "👍" also some agreement on your [proposal](https://github.com/crossplane/crossplane/issues/2608#issuecomment-1452690122), @negz. If no one raises any objection in the meantime, tomorrow...

In https://github.com/crossplane/crossplane/pull/3940 I reused the CRD struct straight away, as the only values supported are Webhook and None, the default and current value. Let me know if you see any...

Hello all, I've been putting some thought into this issue and I do agree it makes sense to move the current validation logic to a validating webhook and that it...

Sure, the point is to shift left the validation of the Composed resources generated by a Composition upon its creation/update, so that users can have an immediate feedback in case...

FYI: The design document for Compositions' validation was finally merged (#3756), and we also merged the first step toward implementing what's proposed there, #3921. This first PR is introducing the...

@jbw976, #1476 is about validating Compositions, here we are talking about validating CompositeResourceDefinitions. If I got it correctly, the point here is to catch any error in the schema defined...