Philippe Scorsolini
Philippe Scorsolini
I thought this could help with #5007, but that's about the ~XR's status, which would still result in an error and therefore in the resource being requeued.~ resource refs being...
e2e failures are also on master, we'll have to investigate them, but we can merge this.
I think this is because we used to dry run [here](https://github.com/crossplane/crossplane/blob/13c2d1f42c61d332b065f3b20c1db6e10c773c37/internal/controller/apiextensions/composite/composition_pt.go#L230C24-L230C36) to get the generated name and the code below still assumes the resources to be valid, which in case...
I think this is a duplicate of https://github.com/crossplane/crossplane/issues/5114
@negz, pretty sure, the example here is extremely complicated, but the core issue is the same, patches to the xr not being executed because of a failure applying a composed...
I'd rather deprecate them first for one release, at least. Otherwise we are forcing people using this alpha, but really widely used,feature to also migrate to functions, while native compositions...
We can emit a deprecation warning from the webhook too if marking the field deprecated is not doing that already, I don't think it does, I have to check 🤔
I'm fine promoting the EnvironmentConfig resource to beta as is, the other option would be to move it out of tree, e.g. provider-environment-configs. WDYT @negz?
Totally agree, @negz.