Philippe Scorsolini

Results 221 comments of Philippe Scorsolini

I think we don't handle the rows, that's why `log_rows` set to `on` is not recognised as a pgaudit record 🤔 I'll work on it tomorrow

I remember someone mentioning to use crane to copy images between registries instead of docker and one of the reasons being exactly that docker didn't preserve the manifest when pushing....

I'd suggest adding both for a while, there should be no issue in doing so and the cluster label would be overridden if needed. We can even make the label...

@gbartolini Nono, labels are just additional metadata for each metrics. ``` cnpg_collector_up{cluster="cluster-example"} 1 ``` Should be reported as: ``` cnpg_collector_up{cluster="cluster-example" cnpg_cluster="cluster-example"} 1 ``` Because "cluster" in multi cluster monitoring systems...

> @phisco I am not sure what you mean by I meant that we could add another parameter to the dashboard to let people choose which label they want to...

@onedr0p, https://github.com/cloudnative-pg/cloudnative-pg/pull/3075 was just merged, as per the comment [here](https://github.com/cloudnative-pg/cloudnative-pg/pull/3075#issuecomment-1793802677) this is not a complete fix as the real issue is with the grafana dashboard lacking the ability to change...

@achanda just for the sake of completeness, as long as we handle that properly, I don't see a reason not to allow that right away. Not a strong requirement though.

Awesome! Thanks, @achanda! The code looks good, I'll give it a spin tomorrow 🙏

@achanda, indeed, dropping all descriptions would be a solution, but unfortunately I don't think that would be an acceptable solution 😬 we do want to have descriptions in the CRDs,...