Phillip Webb

Results 467 comments of Phillip Webb

Writing a log file that never gets rotated could lead to disk space issues if the application runs for a long time. Have you seen the [logback file rotation properties](https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#features.logging.file-rotation)...

The `resourceLoadClass` is optional but quite useful when you organize resources in the same package as your test. It allows you to do `assertThat(tester.write(object)).isEqualToJson("expected.json")` rather than `assertThat(tester.write(object)).isEqualToJson("org/example/app/test/json/expected.json")`

Thanks very much for the PR @asomov. Although 724f9ebf7107d99ac9bae4204b4f7c6444a49e03 is not ideal, out current `main` branch no longer needs that check and [doesn't look too bad](https://github.com/spring-projects/spring-boot/blob/a8168515829c779f2436117b3c53f1315b1d6715/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/env/OriginTrackedYamlLoader.java#L169). I'm a little concerned...

@krisiye Sorry, no ETA. It's in the 3.x milestone which means we think it makes sense for a 3.x release, but we don't know when we'll get to it.

I think the documentation might be a little confusing in this area. The `logging.file.name` property is transferred to a system property named `LOG_FILE` so that it can be referenced in...

It looks like a `ServiceLoader` could be used to plug-in a custom `ch.qos.logback.classic.spi.Configurator`, however, I don't think our logging initialization code would detect that happened and we we'd probably end...

Ahh yes, thanks @dreis2211. It'll be interesting to see if we can support older and newer JDKs at the same time.

I'm not sure if it's best under `spring.rabbit` or `management.metrics`. We could have `spring.rabbitmq.metrics.micrometer.prefix` but I'd probably lean more towards `management.metrics.rabbit.prefix`. Especially as we have things like `management.metrics.mongo.command.enabled` under `management.metrics`...

Hi @lower-case, Thanks for looking at this. I jotted the issue down whilst working on something else so it's a bit light on details and I'm not really sure how...

We're going to investigate if we can add a `no-fork` option or variant.