spring-boot icon indicating copy to clipboard operation
spring-boot copied to clipboard

Annotate EndpointCloudFoundryExtension with @AliasFor

Open mhalbritter opened this issue 3 years ago • 5 comments
trafficstars

Got this warning in my log:

o.s.c.annotation.AnnotationTypeMapping   : Support for convention-based annotation attribute overrides is deprecated and will be removed in Spring Framework 6.1. Please annotate the 'endpoint' attribute in @org.springframework.boot.actuate.autoconfigure.cloudfoundry.EndpointCloudFoundryExtension with an appropriate @AliasFor declaration.

I guess this is an oversight that it's not annotated with @AliasFor.

mhalbritter avatar Jul 08 '22 09:07 mhalbritter

Interesting, I wonder if we might find a few more of those.

philwebb avatar Jul 08 '22 10:07 philwebb

I'm not 100% certain that it's directly related, but I'm getting some of those via Hibernate's @URL validator too since 3.0-M4:

2022-09-26 15:32:23.243  WARN [                                main]   o.s.c.annotation.AnnotationTypeMapping : Support for convention-based annotation attribute overrides is deprecated and will be removed in Spring Framework 6.1. Please annotate the 'flags' attribute in @org.hibernate.validator.constraints.URL with an appropriate @AliasFor declaration -- for example, @AliasFor(annotation = jakarta.validation.constraints.Pattern.class).
2022-09-26 15:32:23.243  WARN [                                main]   o.s.c.annotation.AnnotationTypeMapping : Support for convention-based annotation attribute overrides is deprecated and will be removed in Spring Framework 6.1. Please annotate the 'groups' attribute in @org.hibernate.validator.constraints.URL with an appropriate @AliasFor declaration -- for example, @AliasFor(annotation = jakarta.validation.constraints.Pattern.class).
2022-09-26 15:32:23.243  WARN [                                main]   o.s.c.annotation.AnnotationTypeMapping : Support for convention-based annotation attribute overrides is deprecated and will be removed in Spring Framework 6.1. Please annotate the 'message' attribute in @org.hibernate.validator.constraints.URL with an appropriate @AliasFor declaration -- for example, @AliasFor(annotation = jakarta.validation.constraints.Pattern.class).
2022-09-26 15:32:23.243  WARN [                                main]   o.s.c.annotation.AnnotationTypeMapping : Support for convention-based annotation attribute overrides is deprecated and will be removed in Spring Framework 6.1. Please annotate the 'payload' attribute in @org.hibernate.validator.constraints.URL with an appropriate @AliasFor declaration -- for example, @AliasFor(annotation = jakarta.validation.constraints.Pattern.class).
2022-09-26 15:32:23.243  WARN [                                main]   o.s.c.annotation.AnnotationTypeMapping : Support for convention-based annotation attribute overrides is deprecated and will be removed in Spring Framework 6.1. Please annotate the 'regexp' attribute in @org.hibernate.validator.constraints.URL with an appropriate @AliasFor declaration -- for example, @AliasFor(annotation = jakarta.validation.constraints.Pattern.class).

Tristan971 avatar Sep 26 '22 14:09 Tristan971

@Tristan971 Thanks, but that isn't related to this issue. Can you please open a Spring Framework issue for those warnings? There's little point in it recommending a change to a Hibernate Validator annotation over which you have no control.

wilkinsona avatar Sep 26 '22 14:09 wilkinsona

Got it; done in https://github.com/spring-projects/spring-framework/issues/29206 and sorry for the noise then 😅

Tristan971 avatar Sep 26 '22 14:09 Tristan971

Thanks!

wilkinsona avatar Sep 26 '22 14:09 wilkinsona

Can I do this one?

bbulgarelli avatar Jun 03 '23 19:06 bbulgarelli

Yes please @bbulgarelli, I'll assign it to you.

philwebb avatar Jun 03 '23 20:06 philwebb

Closing in favor of PR #35716. Thanks @bbulgarelli!

philwebb avatar Jun 06 '23 18:06 philwebb