Phil Clay

@philwebb, Yes, I agree that given a git sha and/or app version from the info endpoint, you can do additional detective work to figure out what was packaged within an...

Thanks for the contribution! Love the idea. Allow me some time to investigate it. I want to understand the lumberjack protocol a bit, and do some testing myself before merging...

Is this for lumberjack protocol v1 or v2 ? Whichever version is used needs to be explicitly stated in documentation, and potentially in the classnames (e.g. LumberjackV2...) (edit: I now...

Nice! The removal of the PayloadConverter looks much cleaner and self-contained. Thanks for that update. I have one more major concern to discuss. This implementation claims to implement the full...

Does spring-cloud-gcp logging allow appending arbitrary "raw" JSON to their JSON event output? If so, it could: 1. create a `JsonGenerator` that writes to a string, 2. call `logstashMarker.writeTo(JsonGenerator)` 3....

That's unfortunate. The limitations of JsonLayout are one of the reasons logstash-logback-encoder exists ;) The LogstashMarkers weren't really designed to be consumed by anything other than the encoders within logstash-logback-encoder....

I think the current implementation is "compatible" with both your original idea in #473 (approach 1) and your latest comment here (approach 2). For example, with the code in this...

Hmm. Brainstorming here... What about having a global `omitEmptyFields` boolean property on the encoder honored by all providers, but also being able to be overridden on individual providers? Maybe something...

Interesting idea. Looking at the existing providers for logging events, the following could contribute to a static schema, or validate a given schema at startup: - timestamp - version -...

> in 'please generate a schema' mode with dynamic elements, the schema generation is deferred until the first logged event rather than done at init time Hmm. This won't really...