Phil Clay

Results 60 comments of Phil Clay

Regarding _schema validation mode_, you've sold me. I'm willing to accept a PR for this if you want to submit one. However, _schema generation mode_ is still a little unclear...

Feel free to submit a PR. I'd like to take a look at the implementation so that I can get a better understanding of how schema generation mode looks. But...

(Sorry for the delay. I'll try to be quicker in the future) Looks pretty good so far. I added some minor comments inline on [the commit in your repo](https://github.com/jhalliday/logstash-logback-encoder/commit/fbf6c08a9948ac6c2579373b7356666dc4743b41) I'm...

@littleapp Yes, stalled. The only approach right now is to perform schema validation on the destination side.

> I'm wondering if a better alternative would be to output the original string value in another field whose name is derived from the original. I really like this idea....

> Is it expected? It is expected that logstash-logback-encoder can provide the following guarantees (which it does by default): A) thread names can be easily associated to logging (satisfied by...

Appender listeners have been added in 5.0. The listeners give you the ability to monitor the appenders. The behavior requested in this ticket could be implemented with a listener. i.e....

The markers provided by logstash-logback-encoder support complex JSON output: nested objects, arrays, raw json, etc. Whereas logfmt only supports key/value pairs. How do you propose handling complex types in logfmt?

> The catch to this is that I don't think the format of complex StructuredArguments is explicitly documented, and that probably needs to be a thing. Hmm, yeah, it's not...