Phil Clay

Results 60 comments of Phil Clay

Makes sense. Contributions welcome. I'd prefer the new flag to be named `writeNonStructuredArgumentsAsString`, default false.

Oh nice. I was not aware of the `Unload Module` feature. That sounds like a decent solution for IntelliJ. I'll give it a shot the next time I'm working on...

Unloading Modules in IntelliJ has been a huge help. I've submitted https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/9810 to add this info to the IntelliJ Setup and Troubleshooting doc. Thanks for pointing it out @tylerbenson

One example would be for a binary style RPC protocol where a service/method is identified by ids rather than names. The names might not be known at the start of...

One possible workaround for this limitation is to create: * `DeferredAttributesExtractor` implements `AttributesExtractor` * `onStart` method does nothing * `onEnd` method delegates to an `RpcServerAttributesExtractor` by calling onStart _and_ onEnd....

The main use case is for specifying the token type/format... "opaque" or "jwt" for now, but possibly others in the future. Ideally this attribute could be specified at the provider...

Another engineer on my team, @eurythmia, would like to work on this and submit a PR. Might be a while before we can get to it though.

We've had some changes in priorities on our side and will not be able to get to this for a while longer. If anyone else wants to pick this up...

I still think it will be somewhat beneficial to not require all of the raw bytes from the payload to be in memory at the same time. I understand that...

Thanks for considering this. I definitely agree it requires more investigation to determine the right balance. > For memory use, suppose we have a 1 MB body. For WebFlux it...