Philipp Oppermann
Philipp Oppermann
Thanks for the PR! I'm not sure whether it's a good idea to implicitly change the working directory based on the number of machines. But we could add a config...
> Would prefer to have a separate PR for working directory as we wanted to have abs path only for this PR. The abs path only is implemented in #538.
Triage: I resolved the conflict with the `main` branch. I think this PR is ready for another review @haixuanTao .
I just tried it a few times with the `main` branch but I couldn't reproduce this issue. But I noticed that the example is now combining pip-installed nodes and with...
> To move forward with this PR, we need to remove `std::env::current_exe().` : > > https://github.com/dora-rs/dora/blob/edf22da8f16272d16847a29b98ea21d91440e86c/binaries/cli/src/up.rs#L86 I replaced the `current_exe` calls with a `dora_cli_path` parameter in ce18beb. We still need...
I'm not sure if `which` is good idea. There is no guarantee that `dora` is installed, that it is in the `PATH`, and that it's the same version as the...
Yeah, I'm not a fan of using `fork` either. > > deamon/coordinator/runtime as threads. > > That could be a good idea and it could scope the up environment to...
> FYI, I have fixed this issue for the daemon and the coordinator with: Unfortunately, that's different because this is invoked from the CLI directly. The `run` function, on the...
Closed in favor of #1011
There was some nightly breakage in that specific Rust nightly. The next nightly fixed this again (511364e78 2023-03-16).