Philipp Oppermann comments

Results 676 comments of


                                            Philipp Oppermann

Fix: Add MLX node in dora node-hub #882

There seems to be another PR that implements the same thing at https://github.com/dora-rs/dora/pull/985 ? Should this be closed in favor of #985? cc @Clement795

`EntryOptions::stack_index` panics when stack index is not set (when `Debug` is called on `EntryOptions`)

Thanks for reporting! I think this was fixed already in https://github.com/rust-osdev/x86_64/pull/522, but not released yet.

Idea: Visual Graph Editor for YAML Configuration

Very nice!

Doc: Wrong Zenoh Doc link

Thanks for reporting! A PR for would be appreciated!

windows c++ not work

We never found the time to figure out the necessary linker flags for building on Windows. A pull request that removes this early-exit and adds the correct flags instead would...

Making `dora_cli::command` public

There seem to be some sdist issues on the CI.

Implement conversion traits for PhysAddr and VirtAddr

Thanks for the PR! Looks all reasonable to me. cc @josephlr @Freax13 What do you think about these new impls?

`PageTableEntry::frame` misleadingly returns 4KiB frames for >4KiB frames

Thanks for bringing this to our attention @ChocolateLoverRaj! Unfortunately, I don't see a good way to solve this either. The `PageTableEntry` comes from a `PageTable`, which is also not aware...

`PageTableEntry::frame` misleadingly returns 4KiB frames for >4KiB frames

As an alternative, we could add an `is_level_1_entry` argument to the `frame` method. This way, we could keep the old behavior and keep returning the `HUGE_PAGE` error. This would also...

`update_flags` does not add flags to parent page tables

In the `Mapper::map_to` function, we automatically set the `PRESENT`, `WRITABLE` and `USER_ACCESSIBLE` flags for the parent table if required. We also have `Mapper::map_to_with_table_flags` with an explicit `parent_table_flags` argument. It probably...