Philipp Oppermann

Results 676 comments of Philipp Oppermann

> > Option 1: Use the working directory of the daemon by default (i.e. the directory where the daemon was started in) > > I think that if this is...

I opened a draft PR that implements option 2 a few days ago, maybe that's useful: https://github.com/dora-rs/dora/pull/534 One challenge is the `multiple-daemons` test, which runs on multiple machines, which all...

Thanks a lot for testing and reporting these issues! This is very useful! > * if cli and coordinator are local, some daemons are on remote machines, when dora start,...

My motivation is that it makes it easier to debug issues such as #515. There is currently no way for nodes to know whether inputs were dropped intentionally or because...

Alternative idea: Instead of adding a new event type, we could add a `dropped: usize` field to `Input` events. This way, we don't have the additional overhead of an extra...

> Instead of adding a new event type, we could add a `dropped: usize` field to `Input` events. I pushed some new commits that implement this approach. It's a much...

I think it makes sense to implement both option 1 and option 2. There will always be cases where our safe abstractions are not a good fit, so we should...

@hbuxiaofei Could you please try whether this PR fixes #530 for you?

Thanks for testing! > And there are some small problems, some warning logs will appear. Hmm, this warning indicates that the re-watching failed, so subsequent file changes will be ignored....

Could you post the relevant parts of your vim config. I'm trying to reproduce this, but I keep getting normal `Modify` events. > After adding the ModifyKind::Metadata and ModifyKind::Name events,...