Add macOS-only mlx-lm node to node-hub (#882)
This PR addresses issue #882 by adding support for mlx-lm in the dora node-hub.
Changes:
- Added
mlx-lmnode for macOS compatibility (node-hub/mlx-lm.py). - Made
mlx-lmmacOS-only withplatform.system()check to skip execution on Linux/Windows, fixing CI failures. - Tested locally on macOS 15.4 with
mlx-lmversion 0.23.0.
Notes:
-
mlx-vlmsupport is not included and can be addressed separately. - CI Python tests should now pass across all platforms due to platform check.
Addresses #882 (partially, as mlx-vlm is not implemented).
@haixuanTao Please review this updated PR for adding mlx-lm support.
@haixuanTao The CI failed due to node-hub/dora-mlx-lm/ depending on mlx-lm, which isn’t available on Linux/Windows. I removed it and used node-hub/mlx-lm.py. Do I need to modify the CI workflow to test mlx-lm only on macOS?
Can you put it in the skip folder?
See: https://github.com/dora-rs/dora/blob/66bf1b74a42f6832f2d5b793c53d7e2069bc298b/.github/workflows/node_hub_test.sh#L8
@haixuanTao skipping tests wasn't enough because the pyproject.toml still declares the mlx dependency, which gets resolved during linting and installation steps, causing failures. Moving the folder to ignored_folders prevents any CI steps (install, lint, test) from running on it. PR ready for review, thanks in advance!
That makes sense. Thanks!
Triage: I resolved the conflict with the main branch. I think this PR is ready for another review @haixuanTao .