Gilad Peleg

Results 70 comments of Gilad Peleg

``` js // Use as a regular binding var bindings = domBindings({ 'model.name': { type: 'text', selector: '.any-selector', transform: function(value, binding) { return value + '%'; } } }); ```

I was suggesting a `transform` function that will be run (if defined) before applying the value to whatever the binding type is. I think we're talking about different problems...

I actually think the custom binding function should receive the binding object. Adding it is pretty simple and it totally backwards compatible (add another param to the custom function). It...

Absolutely agree. `change:valid` should not trigger a `parent.update()`.

No I think update should update the parent on value changes, not on valid changes?

The `save` method with `patch:true` imitates how Backbone behaves in this scenario. There are 2 easy options to run dirty checking: - `model.changedAttributes` - changes since the last set. My...

This is something that needs to be resolved on `ampersand-model`. `amp-sync` is just a wrapper for `xhr`

For Models: https://github.com/AmpersandJS/ampersand-model/blob/master/README.md#ajaxconfig-modelajaxconfig-or-modelajaxconfig For Collections: https://github.com/AmpersandJS/ampersand-rest-collection#ajaxconfig-ampersandrestcollectionextend-ajaxconfig-function-----

Yeah I agree.. Although a lot of the `ajaxConfig` are similar between any module that relies on `&-sync`