ampersand-sync icon indicating copy to clipboard operation
ampersand-sync copied to clipboard

withCredentials can be provided directly in options

Open naugtur opened this issue 9 years ago • 3 comments

xhr supports withCredentials option for a while now and the docs describing aompersand-sync should not say that you need xhrFields to add withCredentials as a typical case.

(help me find the file and I can PR it)

naugtur avatar May 29 '15 20:05 naugtur

For Models: https://github.com/AmpersandJS/ampersand-model/blob/master/README.md#ajaxconfig-modelajaxconfig-or-modelajaxconfig

For Collections: https://github.com/AmpersandJS/ampersand-rest-collection#ajaxconfig-ampersandrestcollectionextend-ajaxconfig-function-----

pgilad avatar Aug 02 '15 11:08 pgilad

There's been much more changes since I created this issue... Thanks for pointing to those. I see other modules are documented in READMEs so it's probably best to doscument sync in its README first, and then fill in the above.

naugtur avatar Aug 02 '15 11:08 naugtur

Yeah I agree.. Although a lot of the ajaxConfig are similar between any module that relies on &-sync

pgilad avatar Aug 02 '15 12:08 pgilad