Gilad Peleg

Results 70 comments of Gilad Peleg

Hey thanks for adding the test, but what I would expect the test to validate is that by changing `serialize` to `toJSON` for child-models you get the same output. What...

:apple: +1

@wilmoore I like those changes, they are minor and non-breaking. Can we get some feedback from other Joi users? if this change is good for you, than let's get a...

Your parse is not doing what it's supposed to be doing: ``` js parse: function (data) { data.name = data._reallystupidattributename; return data; } ``` Is basically manipulating the data. `parse`...

Don't mind the docs (hopefully you can improve them for the new comers with a PR). Read backbone docs, they are the original concepts behind `ampersand`: http://backbonejs.org/#Collection-parse And http://backbonejs.org/#Model-parse

I see so this was Poo's Law at it's best, as I thought I was actually helpful. Either way I've never needed to parse non-server responses, and perhaps that is...

Can you make a sample repo with the relevant browserify/webpack config? I would make a: 1. Empty basic html page 2. Basic js file with `ampersand-state`, `ampersand-model`, `ampersand-view` and `ampersand-router`...

Hey - see my comments for https://github.com/AmpersandJS/ampersand-state/pull/176#issuecomment-113564552 regarding this topic.

A potential problem with storing references to instances is you need to clean them up otherwise GC won't be able to clean them. On the other hand, we already store...

Just use: ``` js var Graph = require('./models/graph'); //... children: { graph: Graph } ``` and it will be automatically accessible and will bubble events and all ;-) see https://github.com/AmpersandJS/ampersand-state#children-ampersandstateextend-children--profile-profile--