Patrick Gaskin

Results 386 comments of Patrick Gaskin

It appears they've crippled the old v2 dictionaries, at least the English one (they are now empty with a large file named "junk" filled with zeros). Presumably, the licensing expired...

This seems to be a firmware issue (may not be specific to Windows). The following patch can be used as a temporary workaround for now: ```yaml # kobopatch v0.15.0, firmware...

On a slightly unrelated note, @davidfor pointed out how this read-only functionality has been around for a while, but we never ended up noticing it before my work in #3...

@gtalusan, is this a bug in the firmware (the size or issynced check preventing the permission check from actually having an effect)? Also, another bug which is more visible (it's...

Some stuff I've been looking into on 14622: ``` Some context about where Dictionary::isSynced() comes from now that the DB isn't used: 0x6be680 - Dictionary::isSynced() gets the value stored at...

Yay! I've `EDIT: almost (see the comment a few ones down, this was partly a false positive because I missed a step)` tracked down the bug. Now I just need...

For comparison, here's the logs for the automatic sync after installing the Italian dictionary from the settings: ``` May 15 12:22:42 nickel: (dictbug-trace) QNetworkAccessManager::get(QNetworkRequest.url:`https://ssl.google-analytics.com/collect?v=1&tid=UA-6177406-38&cid=1c07203a-97e7-4736-abaf-b5dc36b47513&uid=c72e7cce-ece3-4e3b-9e6f-7b6cf28f189b&av=4.20.14622&an=nickel&sr=758x1024&ul=en-us&cd60=Sleep&cd64=application/x-kobo-epub+zip&t=event&ec=ReadingExperience&ea=OpenContent&el=application/x-kobo-epub+zip`) May 15 12:22:49 nickel: (dictbug-trace) QNetworkAccessManager::get(QNetworkRequest.url:`https://ssl.google-analytics.com/collect?v=1&tid=UA-6177406-38&cid=1c07203a-97e7-4736-abaf-b5dc36b47513&uid=c72e7cce-ece3-4e3b-9e6f-7b6cf28f189b&av=4.20.14622&an=nickel&sr=758x1024&ul=en-us&t=screenview&cd=/AppSettings`)...

Using [this](https://github.com/geek1011/kobo-mods/commit/29321102ecb61969c5e743ae587d63d034296b3f), I've narrowed down further. It's not related to `tmpDictionary` directly, but it's still related to the size check in prepareDownloadList.

This is an educated guess (I'm still looking at it), but I think the issue can be fixed by swapping the order of the size/permission checks so permissions come first....

An update for the comment a few ones above (I missed the FileSizeGetter stuff, which is probably why some parts of this bug didn't make complete sense to me after...