Vadim Petrochenkov comments

Results 344 comments of


                                            Vadim Petrochenkov

resolve: Preserve ambiguous glob reexports in crate metadata

>We'd also like to see a def-site warning about these cases paired with this >I think a def-site warning is important to "shift left" failures like this. We already have...

resolve: Preserve ambiguous glob reexports in crate metadata

@traviscross >74 regressions are just due to `ambiguous_glob_imports` being deny-by-default. >We could potentially introduce a separate warn-by-default lint `extern_ambiguous_glob_imports` to soften the transition. Is there some decision on this ^^^...

resolve: Split `Scope::Module` into two scopes for non-glob and glob bindings

There may be minor breakage in corner cases due to ambiguity checking being unified between in-scope resolution and in-module resolution, so this needs a crater run. @bors try

resolve: Split `Scope::Module` into two scopes for non-glob and glob bindings

@bors try

resolve: Split `Scope::Module` into two scopes for non-glob and glob bindings

@craterbot check

resolve: Report more visibility-related early resolution ambiguities for imports

@bors try

resolve: Report more visibility-related early resolution ambiguities for imports

`@craterbot run mode=check-only p=1 crates=https://crater-reports.s3.amazonaws.com/pr-149145/retry-regressed-list.txt`

resolve: Report more visibility-related early resolution ambiguities for imports

@craterbot run mode=check-only p=1 crates=https://crater-reports.s3.amazonaws.com/pr-149145/retry-regressed-list.txt

resolve: Report more visibility-related early resolution ambiguities for imports

@bors try

resolve: Report more visibility-related early resolution ambiguities for imports

@craterbot run mode=check-only p=1 crates=https://crater-reports.s3.amazonaws.com/pr-149596/retry-regressed-list.txt