Vadim Petrochenkov comments

Results 344 comments of


                                            Vadim Petrochenkov

Make the test cfg a userspace check-cfg

@rfcbot fcp merge

Make the test cfg a userspace check-cfg

Implementation - https://github.com/rust-lang/rust/pull/131729.

resolve: Preserve ambiguous glob reexports in crate metadata

@bors try

resolve: Preserve ambiguous glob reexports in crate metadata

cc @LorrensP-2158466 @bvanjoi

resolve: Preserve ambiguous glob reexports in crate metadata

@craterbot check

resolve: Preserve ambiguous glob reexports in crate metadata

That's a lot of breakage. Mostly from dependencies, including various version of `openssl` that we've seen previously. I'll demote this error to always be reported as a lint in cross-crate...

resolve: Preserve ambiguous glob reexports in crate metadata

@bors try `@craterbot run mode=check-only p=1 crates=https://crater-reports.s3.amazonaws.com/pr-147984/retry-regressed-list.txt`

resolve: Preserve ambiguous glob reexports in crate metadata

@craterbot run mode=check-only p=1 crates=https://crater-reports.s3.amazonaws.com/pr-147984/retry-regressed-list.txt

resolve: Preserve ambiguous glob reexports in crate metadata

74 regressions are just due to `ambiguous_glob_imports` being deny-by-default. We could potentially introduce a separate warn-by-default lint `extern_ambiguous_glob_imports` to soften the transition. There are 3 other non-spurious regressions from this...

resolve: Preserve ambiguous glob reexports in crate metadata

#### Change description for the lang team This PR implements a long stanging missing piece in cross-crate reexports. Currently ambiguous glob imports/reexports produce an error like this on local use....